rubenada commented on code in PR #4100:
URL: https://github.com/apache/calcite/pull/4100#discussion_r2002732531
##########
core/src/main/java/org/apache/calcite/jdbc/CalciteSchema.java:
##########
@@ -322,7 +322,6 @@ public final NavigableMap<String, CalciteSchema>
getSubSchemaMap() {
final ImmutableSortedMap.Builder<String, CalciteSchema> builder =
new ImmutableSortedMap.Builder<>(NameSet.COMPARATOR);
builder.putAll(subSchemaMap.map());
- addImplicitSubSchemaToBuilder(builder);
Review Comment:
@kramerul Sorry, I'm late to the party here. Quick question: isn't this a
breaking change? Previously `getSubSchemaMap` would return both the explicit
and implicit sub-schema (as its javadoc states), but now the implicit ones
would no longer be considered? (I guess those could still be accessed via the
new `subSchemas()` method), but it'd seem that `getSubSchemaMap` has changed
its behavior (and its javadoc is no longer accurate). Or I'm missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
