NobiGo commented on code in PR #4235:
URL: https://github.com/apache/calcite/pull/4235#discussion_r2008458444
##########
core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java:
##########
@@ -166,4 +173,36 @@ public HiveSqlDialect(Context context) {
}
return super.getCastSpec(type);
}
+
+ /**
+ * Rewrite SINGLE_VALUE.
Review Comment:
Fixed.
##########
core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java:
##########
@@ -166,4 +173,36 @@ public HiveSqlDialect(Context context) {
}
return super.getCastSpec(type);
}
+
+ /**
+ * Rewrite SINGLE_VALUE.
+ *
+ * <pre>In Hive, ASSERT_TRUE(false) will throw assertion failed
exception.</pre>
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
