NobiGo commented on code in PR #3191:
URL: https://github.com/apache/calcite/pull/3191#discussion_r2009967612
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -180,6 +180,20 @@ class JdbcAdapterTest {
+ "WHERE \"product_id\" = 1) AS \"t3\"");
}
+ @Test void testUnionIncludingCte() {
+ CalciteAssert.model(FoodmartSchema.FOODMART_MODEL)
Review Comment:
This test case can be executed without any modification. Please reconfirm it.
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -4439,20 +4439,29 @@ private void validateModality(SqlNode query) {
// SQL: WITH STREAMTABLE AS (SELECT STREAM * FROM KAFKA.MOCKTABLE)
// SELECT STREAM * FROM STREAMTABLE
// The modality should be STREAM.
- validateModality(((SqlWith) query).body);
+ SqlWith with = (SqlWith) query;
Review Comment:
I hope the code comments here can also provide some explanations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
