xuzifu666 commented on code in PR #4261:
URL: https://github.com/apache/calcite/pull/4261#discussion_r2017983875
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -1364,6 +1364,47 @@ private static String toSql(RelNode root, SqlDialect
dialect,
sql(query).ok(expected);
}
+ /**
+ * Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6909";>[CALCITE-6909]
+ * ClickHouse Dailect can not support accurate precision</a>.
+ */
+ @Test void testClickHouseCastDecimalPrecision() {
Review Comment:
Thanks @NobiGo , I had changed the test case，before the pr would error out：
Expected: is "SELECT CAST(`product_id` AS DECIMAL(75, 12))\nFROM
`foodmart`.`product`"
but: was "SELECT CAST(`product_id` AS DECIMAL(19, 12))\nFROM
`foodmart`.`product`"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
