xuzifu666 commented on PR #4279: URL: https://github.com/apache/calcite/pull/4279#issuecomment-2768033862
> If that test works before and after your change, it means that it is not covering your changes. Yes，this PR is just a refactoring. before the PR: PrestoSqlDialect##unparseCall default part extend from PostgreSqlDialect##unparseCall , I worry about that if future changed code in PostgreSqlDialect##unparseCall would impact PrestoSqlDialect##unparseCall directly, If contains some feature change different from Presto and developer not change also in Presto would bring risk，as I know Presto syntax contains much differences to PostgreSQL. after the PR: PrestoSqlDialect is independent from any other Dialect. Maybe this way is suitable. Do you agree with me or contains other suggestion？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
