mihaibudiu commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2029555364
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -166,8 +166,12 @@ public abstract class SqlImplementor {
protected final Map<CorrelationId, Context> correlTableMap = new HashMap<>();
- /** Private RexBuilder for short-lived expressions. It has its own
- * dedicated type factory, so don't trust the types to be canonized. */
+ /**
+ * Private RexBuilder for short-lived expressions. It has its own
+ * dedicated type factory, so don't trust the types to be canonized.
+ *
+ * @deprecated Replaced by {@link RexBuilder#DEFAULT}. */
+ @Deprecated // to be removed before 2.0
Review Comment:
Well, I approved the PR.
But it would be good to know why this method needs to be essentially
deprecated (because it can't be used).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
