xiedeyantu commented on PR #4280: URL: https://github.com/apache/calcite/pull/4280#issuecomment-2784975242
> > > This looks pretty good, and it is surprisingly short given how much it accomplishes. I still have an algorithmic question, about the nature of the expressions in the OR. > > > > > > Sorry, I may not understand what you mean. What question about OR do I need to reply to? > > This expansion is most useful when some of the orConds are conjunctions of table columns. In fact, I think you don't even need to expand ALL the orConds, you could stop after one of them. Is it worth analyzing the orConds and making a list of the ones that can lead to conjunctions that can be efficiently handled by equijoins and expanding only these? I agree with you. In fact, I considered this in my initial view. You can check if `isSimpleCondition` is what you mean (maybe the name needs to be changed). The link is [here ](https://github.com/apache/calcite/commit/749c0725643cf3eb7953b236c0595966198d606d#diff-5761c993bb47ab9756426564eb187d027412f8e6469a0c0df8ce0935d2222fd8R7-R121) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
