xiedeyantu commented on code in PR #4288:
URL: https://github.com/apache/calcite/pull/4288#discussion_r2032121424
##########
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##########
@@ -1918,31 +1918,24 @@ public RexLiteral makeZeroLiteral(RelDataType type) {
}
public RexNode makeZeroForNestedType(RelDataType type) {
+ SqlOperator op;
switch (type.getSqlTypeName()) {
case ARRAY:
- ArraySqlType arrayType = (ArraySqlType) type;
- RexNode zeroElement =
makeZeroForNestedType(arrayType.getComponentType());
- return makeCall(type, SqlStdOperatorTable.ARRAY_VALUE_CONSTRUCTOR,
- ImmutableList.of(zeroElement));
+ op = SqlStdOperatorTable.ARRAY_VALUE_CONSTRUCTOR;
Review Comment:
You mean to keep the actual type and the writing consistent to avoid
problems with `CAST(ARRAY[] AS type)` in SQL, right? I'll think about it and
may need to adjust it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
