mihaibudiu commented on code in PR #4288:
URL: https://github.com/apache/calcite/pull/4288#discussion_r2031796643
##########
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##########
@@ -1918,31 +1918,24 @@ public RexLiteral makeZeroLiteral(RelDataType type) {
}
public RexNode makeZeroForNestedType(RelDataType type) {
+ SqlOperator op;
switch (type.getSqlTypeName()) {
case ARRAY:
- ArraySqlType arrayType = (ArraySqlType) type;
- RexNode zeroElement =
makeZeroForNestedType(arrayType.getComponentType());
- return makeCall(type, SqlStdOperatorTable.ARRAY_VALUE_CONSTRUCTOR,
- ImmutableList.of(zeroElement));
+ op = SqlStdOperatorTable.ARRAY_VALUE_CONSTRUCTOR;
Review Comment:
What is the type of the constructed array?
I wonder whether this will create problems because the type needs to be
inferred.
But you know the type already, so you can synthesize a `CAST(ARRAY[] AS
type)`.
Same below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
