suibianwanwank commented on code in PR #4280:
URL: https://github.com/apache/calcite/pull/4280#discussion_r2038994412
##########
core/src/main/java/org/apache/calcite/rel/rules/JoinCommuteRule.java:
##########
@@ -137,6 +137,12 @@ public JoinCommuteRule(Class<? extends Join> clazz,
.build();
}
+ public static RexNode swapJoinCond(RexNode cond, Join join, RexBuilder
rexBuilder) {
Review Comment:
I don't know if there's a practice where one rule references another rule's
method, but generally, rules should be independent. You could try moving the
method outside the rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
