mihaibudiu commented on code in PR #4301:
URL: https://github.com/apache/calcite/pull/4301#discussion_r2045178436


##########
core/src/test/resources/sql/planner.iq:
##########
@@ -59,9 +59,9 @@ EnumerableNestedLoopJoin(condition=[IS NOT DISTINCT FROM($0, 
$1)], joinType=[sem
     EnumerableValues(tuples=[[{ 0 }, { 1 }]])
 !plan
 
-!set reset-rules ""
+!set planner-rules original
 
-# Test reset-rules can reset init rules
+# Test that rules set by "!set planner-rules original" are sticky

Review Comment:
   "sticky" means that they can be reused across multiple tests. 
   this is not what you are testing here.
   you are really testing that this brings back the original rules (to some 
degree)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to