xuzifu666 commented on PR #4314: URL: https://github.com/apache/calcite/pull/4314#issuecomment-2813516287
> This looks fine. > However, the title is confusing; I would say "unparsing STARTS_WITH is incorrect for the Clickhouse dialect". > You are also introducing a new SQL dialect in this PR. Should that be a separate PR that we merge prior to this one? Do you plan to analyze all functions and tag the ones available in Clickhouse? > It may be confusing to users if the dialect exists and only some functions are tagged. > One solution is to file a new issue about marking Clickhouse dialect functions Make sense, I would work as your suggestion, thanks~@mihaibudiu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
