NobiGo commented on PR #4321: URL: https://github.com/apache/calcite/pull/4321#issuecomment-2815875789
> What's the relation between this and #4312? This PR can be directly replaced with #4321. After this PR, we can solve the only existing XML methods by copying and pasting the file_actual.xml and don't need to delete them one by one. In addition, the exception information will be clearer. For example, in PR's unit test DiffRepositoryTest#testMethodOnlyExistsInXml: The exception will be: ``` java.lang.IllegalArgumentException: Actual and reference files differ. If you are adding new tests, replace the reference file with the current actual file, after checking its content. diff /calcite/testkit/build/diffrepo/test/org/apache/calcite/test/DiffRepositoryTest_actual.xml /calcite/testkit/src/test/resources/org/apache/calcite/test/DiffRepositoryTest.xml 26d25 < <TestCase name="testMethodOnlyExistsInXml1"/> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
