joewee commented on code in PR #4319: URL: https://github.com/apache/calcite/pull/4319#discussion_r2051315843
########## core/src/test/java/org/apache/calcite/sql/SqlCallOperandsTest.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql; + +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql.parser.SqlParserPos; + +import org.junit.jupiter.api.Test; + +import java.util.List; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.equalTo; +import static org.hamcrest.Matchers.hasSize; + +/** + * Tests for SqlCall operands' order and size match with set. + * See <a href="https://issues.apache.org/jira/browse/CALCITE-6964";>[CALCITE-6964]</a> + * + */ +public class SqlCallOperandsTest { + @Test void testSqlDeleteGetOperandsMatchWithSetOperand() { + SqlDelete sqlDelete = + new SqlDelete(SqlParserPos.ZERO, new SqlIdentifier("table1", SqlParserPos.ZERO), + null, + null, + null); + SqlNode targetTable = new SqlIdentifier("table2", SqlParserPos.ZERO); + final SqlIdentifier field1 = new SqlIdentifier("field1", SqlParserPos.ZERO); + SqlNode condition = + SqlStdOperatorTable.EQUALS.createCall(SqlParserPos.ZERO, field1, + SqlLiteral.createCharString("field1Value", SqlParserPos.ZERO)); + SqlSelect sourceSelect = + new SqlSelect(SqlParserPos.ZERO, null, + SqlNodeList.of(field1), + null, + null, + null, + null, + null, + null, + null, + null, + null, + null); + SqlIdentifier alias = new SqlIdentifier("alias", SqlParserPos.ZERO); + sqlDelete.setOperand(0, targetTable); + sqlDelete.setOperand(1, condition); + sqlDelete.setOperand(2, sourceSelect); + sqlDelete.setOperand(3, alias); + final List<SqlNode> operandList = sqlDelete.getOperandList(); Review Comment: Maybe the test case method name is ambiguity, this case purpose is ensure getOperandList return operands' order and size match with setOperand to solve getOperandList return a mismatch size and order operands like before: ` @Override public List<SqlNode> getOperandList() { return ImmutableNullableList.of(targetTable, condition, alias); }` So should i modify the test method name to 'testSqlDeleteGetOperandsSizeAndOrderMatchWithSetOperand' ? @mihaibudiu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
