NobiGo commented on code in PR #4314: URL: https://github.com/apache/calcite/pull/4314#discussion_r2051852190
########## site/_docs/reference.md: ########## @@ -2876,7 +2878,7 @@ In the following: | b | DATE_TRUNC(date, timeUnit) | Truncates *date* to the granularity of *timeUnit*, rounding to the beginning of the unit | o r s h | DECODE(value, value1, result1 [, valueN, resultN ]* [, default ]) | Compares *value* to each *valueN* value one by one; if *value* is equal to a *valueN*, returns the corresponding *resultN*, else returns *default*, or NULL if *default* is not specified | p r | DIFFERENCE(string, string) | Returns a measure of the similarity of two strings, namely the number of character positions that their `SOUNDEX` values have in common: 4 if the `SOUNDEX` values are same and 0 if the `SOUNDEX` values are totally different -| f s | ENDSWITH(string1, string2) | Returns whether *string2* is a suffix of *string1* +| f s i | ENDSWITH(string1, string2) | Returns whether *string2* is a suffix of *string1* Review Comment: Since these functions have already been enabled in the Spark function library, you can directly use `sql(query).withLibrary(SqlLibrary.SPARK).withClickHouse().ok(expectedClickHouse);` This is two distinct stages. "withLibrary" indicates the functions that users can utilize in Calcite, while "withClickHouse" represents the dialect that needs to be adopted when converting the SqlNode transformed by Calcite into a specific dialect. If we want to add withLibrary(SqlLibrary.CLICKHOUSE), the required test cases will be to input a function with case-sensitive behavior for users, otherwise an unsupported exception message will be thrown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
