mihaibudiu commented on code in PR #4323:
URL: https://github.com/apache/calcite/pull/4323#discussion_r2053384682
##########
core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java:
##########
@@ -71,10 +71,22 @@ public class MysqlSqlDialect extends SqlDialect {
return 65535;
case TIMESTAMP:
return 6;
+ case DECIMAL:
+ return 65;
default:
return super.getMaxPrecision(typeName);
}
}
+
+ @Override public int getMaxScale(SqlTypeName typeName) {
Review Comment:
I think this is wrong:
https://dev.mysql.com/doc/refman/8.4/en/precision-math-decimal-characteristics.html
The docs say that 30 is the max value.
Please double check these values before you make the fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
