NobiGo commented on code in PR #4327:
URL: https://github.com/apache/calcite/pull/4327#discussion_r2055801585
##########
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java:
##########
@@ -112,6 +116,65 @@ public ClickHouseSqlDialect(Context context) {
return CalendarPolicy.SHIFT;
}
+ @Override public RexNode prepareUnparse(RexNode arg) {
Review Comment:
We don't need to write the same code. We can extract this implementation
part to RelToSqlConverterUtil, and different dialects can use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
