mihaibudiu commented on code in PR #4333:
URL: https://github.com/apache/calcite/pull/4333#discussion_r2059617348


##########
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##########
@@ -1077,9 +1077,8 @@ public static SqlSingleOperandTypeChecker same(int 
operandCount,
           SqlTypeFamily.INTEGER);
 
   public static final SqlSingleOperandTypeChecker 
STRING_INTEGER_OPTIONAL_INTEGER =
-      family(
-          ImmutableList.of(SqlTypeFamily.STRING, SqlTypeFamily.INTEGER,

Review Comment:
   they should, but I don't know how to fix the API, because I don't really 
understand the rules.
   I commented about this in the JIRA ticket
   I tried to mark this API Deprecated, but there is still one use I could not 
remove.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to