xiedeyantu commented on code in PR #4336:
URL: https://github.com/apache/calcite/pull/4336#discussion_r2061121123
##########
testkit/src/main/java/org/apache/calcite/sql/test/SqlTestFactory.java:
##########
@@ -130,6 +130,12 @@ protected SqlTestFactory(CatalogReaderFactory
catalogReaderFactory,
/** Creates a parser. */
public SqlParser createParser(String sql) {
+ if (sql.isEmpty()) {
+ // I could not figure out how to convince the grammar to accept an empty
Review Comment:
I'm not very familiar with this place, maybe it's a JavaCC issue as you
said, but it does feel strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
