xiedeyantu commented on code in PR #4342:
URL: https://github.com/apache/calcite/pull/4342#discussion_r2063550204
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -5361,52 +5362,92 @@ private void checkLiteral2(String expression, String
expected) {
/** Test case for
* <a
href="https://issues.apache.org/jira/browse/CALCITE-6949";>[CALCITE-6949]
- * ClickHouse not support floor date to
SECOND/MILLISECOND/MICROSECOND/NANOSECOND</a>. */
+ * ClickHouse not support floor date to
SECOND/MILLISECOND/MICROSECOND/NANOSECOND</a>,
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6988";>[CALCITE-6988]
+ * DuckDB dialect implementation</a>.
+ * */
@Test void testFloorClickHouse() {
Review Comment:
Change the method name to testFloorXxx?
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7842,9 +7890,12 @@ private void checkLiteral2(String expression, String
expected) {
// since it seems to be used across more dialects.
final String expectedSnowflake = "SELECT LENGTH(\"brand_name\")\n"
+ "FROM \"foodmart\".\"product\"";
+ final String expectedDuckDB = "SELECT LENGTH(\"brand_name\")\n"
Review Comment:
same as expectedSnowflake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
