asolimando commented on PR #4324: URL: https://github.com/apache/calcite/pull/4324#issuecomment-2837832326
> > @silundong please avoid force-pushing while the review is still in progress unless strictly necessary to rebase on `main`, by reading the latest comments from Mihai I realized he has asked for changes I already asked and that got lost as the GH UI can't keep up when you force push > > Sorry. I may need to use the new features provided by #4301 to complete the test mentioned by Mihai. As I said, whenever needed it's not a problem, but let's avoid it unless necessary as it makes the review process more complicated. We are anyway always squashing before merging, don't worry about piling up intermediate commits until the PR is finalized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
