mihaibudiu commented on code in PR #4353:
URL: https://github.com/apache/calcite/pull/4353#discussion_r2069722298
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##########
@@ -383,11 +384,16 @@ protected boolean booleanEquality(SqlCallBinding binding,
}
/**
- * CASE and COALESCE type coercion, collect all the branches types including
then
+ * CASE WHEN and COALESCE type coercion, collect all the branches types
including then
* operands and else operands to find a common type, then cast the operands
to the common type
* when needed.
*/
@Override public boolean caseWhenCoercion(SqlCallBinding callBinding) {
+ if (!(callBinding.getCall() instanceof SqlCase)) {
+ // For sql statement like: `coalesce(a, b, c)`
Review Comment:
This is better. The JavaDoc suggests that this was the original intent of
the code too, but maybe it was never realized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
