mihaibudiu commented on code in PR #4360:
URL: https://github.com/apache/calcite/pull/4360#discussion_r2074492132
##########
core/src/main/java/org/apache/calcite/util/RelToSqlConverterUtil.java:
##########
@@ -68,6 +68,43 @@ public static void unparseHiveTrim(
}
}
+ /**
+ * For usage of TRIM, LTRIM and RTRIM in BQ see
+ * <a
href="https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#trim";>
+ * BQ Trim Function</a>,
+ * <a
href="https://prestodb.io/docs/current/functions/string.html#trim-string-varchar";>
+ * Presto Trim Function</a>.
+ */
+ public static void unparseTrim(SqlWriter writer, SqlCall call, int leftPrec,
Review Comment:
the current name is too generic, this function is not suitable for
unparsingTrim for all dialects, as the name would suggest
I think unparseTrimBigQuery is better, or unparseTrimLR if you want.
Many dialects can share it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
