mihaibudiu commented on code in PR #4362:
URL: https://github.com/apache/calcite/pull/4362#discussion_r2076555910


##########
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##########
@@ -1418,6 +1418,8 @@ public enum SqlKind {
           CREATE_TYPE, DROP_TYPE,
           SET_OPTION, OTHER_DDL);
 
+  public static final EnumSet<SqlKind> COLLECTION_EXPRESSION =

Review Comment:
   are MAPS collections?



##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##########
@@ -563,6 +564,44 @@ protected boolean booleanEquality(SqlCallBinding binding,
     return false;
   }
 
+  @Override public boolean quantifyOperationCoercion(SqlCallBinding binding) {

Review Comment:
   is this only when the argument is an array?
   If true, this should be documented.
   (The function probably needs JavaDoc anyway)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to