xiedeyantu commented on code in PR #4366:
URL: https://github.com/apache/calcite/pull/4366#discussion_r2082799934


##########
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##########
@@ -388,9 +388,17 @@ private CoreRules() {}
   public static final IntersectToSemiJoinRule INTERSECT_TO_SEMI_JOIN =
           IntersectToSemiJoinRule.Config.DEFAULT.toRule();
 
+  /** Rule that translates a {@link Union} to {@link Filter}. */
+  public static final SetOpToFilterRule UNION_TO_FILTER =

Review Comment:
   Although the name of this implementation class has been changed (to 
SetOpToFilterRule), the logic of MINUS_TO_FILTER has not been changed and the 
name is still MINUS_TO_FILTER. Can I continue to keep UNION and INTERSECT 
consistent with it (UNOIN_TO_FILTER and INTERSECT_TO_FILTER)?



##########
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##########
@@ -388,9 +388,17 @@ private CoreRules() {}
   public static final IntersectToSemiJoinRule INTERSECT_TO_SEMI_JOIN =
           IntersectToSemiJoinRule.Config.DEFAULT.toRule();
 
+  /** Rule that translates a {@link Union} to {@link Filter}. */
+  public static final SetOpToFilterRule UNION_TO_FILTER =

Review Comment:
   Sorry, please ignore this reply



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to