xuzifu666 commented on PR #4371: URL: https://github.com/apache/calcite/pull/4371#issuecomment-2893579051
Thanks for all comments, had modified as follow: 1. AggregateValuesRule is expanded to 2 modes, handling the default case and deduplication respectively; 2. Deduplication cannot be fully guaranteed for complex types such as Row, so deduplication is performed on non-complex type data of Literal first; 3. Related tests are added. please take a look for the changes. @mihaibudiu @asolimando @xiedeyantu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
