asolimando commented on code in PR #4371:
URL: https://github.com/apache/calcite/pull/4371#discussion_r2099885618
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -19610,6 +19610,46 @@ LogicalProject(DEPTNO=[$0], EXPR$1=[$1],
EXPR$2=[CAST(/($2, $3)):INTEGER NOT NUL
LogicalAggregate(group=[{0, 2}], agg#0=[MIN($1)], agg#1=[MIN($3)])
LogicalProject(DEPTNO=[$7], SAL=[$5], JOB=[$2], COMM=[$6])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testReduceInValues">
+ <Resource name="sql">
+ <![CDATA[SELECT deptno, sal FROM EMP WHERE deptno IN
(1,1,3,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1)]]>
+ </Resource>
+ <Resource name="planBefore">
+ <![CDATA[
+LogicalProject(DEPTNO=[$7], SAL=[$5])
+ LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4],
SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
+ LogicalJoin(condition=[=($7, $9)], joinType=[inner])
+ LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+ LogicalAggregate(group=[{0}])
+ LogicalValues(tuples=[[{ 1 }, { 1 }, { 3 }, { 1 }, { 1 }, { 1 }, { 1
}, { 1 }, { 1 }, { 1 }, { 1 }, { 1 }, { 1 }, { 1 }, { 1 }, { 1 }, { 1 }, { 1 },
{ 1 }, { 1 }, { 1 }]])
+]]>
+ </Resource>
+ <Resource name="planAfter">
+ <![CDATA[
+LogicalProject(DEPTNO=[$7], SAL=[$5])
+ LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4],
SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
+ LogicalJoin(condition=[=($7, $9)], joinType=[inner])
+ LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+ LogicalValues(tuples=[[{ 1 }, { 3 }]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testReduceInValuesWithAggregateValueReduceRule">
+ <Resource name="sql">
Review Comment:
CALCITE-7016 has been filed to track this, let's see where that discussion
leads, we can gloss on this for now here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
