xiedeyantu commented on code in PR #4399:
URL: https://github.com/apache/calcite/pull/4399#discussion_r2107963067


##########
core/src/main/java/org/apache/calcite/tools/Frameworks.java:
##########
@@ -271,13 +273,14 @@ private ConfigBuilder(FrameworkConfig config) {
       typeSystem = config.getTypeSystem();
       evolveLattice = config.isEvolveLattice();
       statisticProvider = config.getStatisticProvider();
+      volcanoRuleSet = config.getVolcanoRuleSet();
     }
 
     public FrameworkConfig build() {
       return new StdFrameworkConfig(context, convertletTable, operatorTable,
           programs, traitDefs, parserConfig, sqlValidatorConfig, 
sqlToRelConverterConfig,
           defaultSchema, costFactory, typeSystem, executor, evolveLattice,
-          statisticProvider, viewExpander);
+          statisticProvider, viewExpander, volcanoRuleSet);

Review Comment:
   StdFrameworkConfig is a private static class, the value of volcanoRuleSet is 
null by default. Maybe there is no need to add new function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to