NobiGo commented on code in PR #4403:
URL: https://github.com/apache/calcite/pull/4403#discussion_r2112994831
##########
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##########
@@ -662,6 +662,9 @@ public enum SqlKind {
/** {@code IS NOT NULL} operator. */
IS_NOT_NULL,
+ /** {@code CAST NOT NULL} operator. */
+ CAST_NOT_NULL,
Review Comment:
I agree with your point. The Rel stage can better address this issue. This
PR takes into account the compatibility of the previous version.This can solve
the problem of CALCITE-6879 without causing any impact on the user, excluding
nondeterministic functions. Moreover, in the comment of `withCallRewrite`, it
is mentioned as "macro-like", so we should try our best to ensure that no
exceptions are thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
