xuzifu666 commented on PR #4400: URL: https://github.com/apache/calcite/pull/4400#issuecomment-2919689169
> This is a feature. The summary should reflect thst. “Eliminate nested TRIM calls, exploiting the fact that TRIM id idempotent”. > > A lot of test code has been added to RelToSqlConverterTest but this issue is not about conversion to a SQL dialect. Put it somewhere better. > > > The sql queries in planner.iq need comments. Say which ones you expect the plan to fold calls, and which ones you expect it to not fold, and why. Otherwise your work will be lost when someone updates the logs. > > Is there a general mechanism for declaring thst functions are ifempotent? Can you give examples of other idempotent functions? I would like you to start thinking about that in the jira case even though there is no code yet. Thanks for your review and suggesttion, I would change as it and make a general mechanism for more idempotent functions in the jira latter.@julianhyde -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
