mihaibudiu commented on code in PR #4403:
URL: https://github.com/apache/calcite/pull/4403#discussion_r2114499225
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlInternalOperators.java:
##########
@@ -224,6 +224,16 @@ private SqlInternalOperators() {
public static final SqlAggFunction LITERAL_AGG =
SqlLiteralAggFunction.INSTANCE;
+ public static final SqlOperator CAST_NOT_NULL =
Review Comment:
I think you should document in the JavaDoc how this operator differs from a
typical CAST, copying some of the discussion above.
##########
core/src/test/resources/sql/sub-query.iq:
##########
@@ -2714,7 +2714,7 @@ where exists
# following plan (two scans of EMP table instead of three).
EnumerableCalc(expr#0..2=[{inputs}], ENAME=[$t1])
EnumerableHashJoin(condition=[=($2, $3)], joinType=[semi])
- EnumerableCalc(expr#0..7=[{inputs}], expr#8=[IS NOT NULL($t3)],
expr#9=[CAST($t3):INTEGER], expr#10=[0], expr#11=[CASE($t8, $t9, $t10)],
proj#0..1=[{exprs}], $f3=[$t11])
+ EnumerableCalc(expr#0..7=[{inputs}], expr#8=[IS NOT NULL($t3)],
expr#9=[CAST($t3):INTEGER NOT NULL], expr#10=[0], expr#11=[CASE($t8, $t9,
$t10)], proj#0..1=[{exprs}], $f3=[$t11])
Review Comment:
I am surprised that so few plans need to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
