xuzifu666 commented on code in PR #4400:
URL: https://github.com/apache/calcite/pull/4400#discussion_r2122515391
##########
core/src/test/java/org/apache/calcite/test/RexImplicationCheckerTest.java:
##########
@@ -360,6 +361,97 @@ public class RexImplicationCheckerTest {
hasToString("2014"));
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7042";>[CALCITE-7042]
+ * Eliminate nested TRIM calls, exploiting the fact that TRIM is
idempotent</a>. */
+ @Test void testSimplifyIdempotentFunctions() {
Review Comment:
Thanks for your idea and case, it is indeed better , here use floor to test
is OK IMO and I had changed with test case. @xiedeyantu
##########
core/src/test/java/org/apache/calcite/test/RexImplicationCheckerTest.java:
##########
@@ -360,6 +361,97 @@ public class RexImplicationCheckerTest {
hasToString("2014"));
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7042";>[CALCITE-7042]
+ * Eliminate nested TRIM calls, exploiting the fact that TRIM is
idempotent</a>. */
+ @Test void testSimplifyIdempotentFunctions() {
Review Comment:
Thanks for your idea and case, it is indeed better, here use floor to test
is OK IMO and I had changed with test case. @xiedeyantu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
