xiedeyantu commented on code in PR #4402:
URL: https://github.com/apache/calcite/pull/4402#discussion_r2127746595


##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -1835,6 +1835,45 @@ private void checkExponentialCnf(int n) {
         "true");
   }
 
+  /** Unit test for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-7032";>[CALCITE-7032]
+   * Simplify 'NULL >ALL (ARRAY[1,2,NULL])' to 'NULL'</a>. */

Review Comment:
   ```suggestion
      * Simplify 'NULL > ALL (ARRAY[1,2,NULL])' to 'NULL'</a>. */
   ```



##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -1835,6 +1835,45 @@ private void checkExponentialCnf(int n) {
         "true");
   }
 
+  /** Unit test for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-7032";>[CALCITE-7032]
+   * Simplify 'NULL >ALL (ARRAY[1,2,NULL])' to 'NULL'</a>. */
+  @Test void testSimplifyQuantifyOperatorsWithArray() {
+    RexNode operand1 = nullInt;
+    RelDataType arrayType = tArray(tInt(true));
+    RelDataType arrayType2 = tArray(tSmallInt(true));
+    RexNode operand2 =
+        rexBuilder.makeCall(arrayType, 
SqlStdOperatorTable.ARRAY_VALUE_CONSTRUCTOR,
+            ImmutableList.of(literal(1), literal(2), nullInt));
+    // "NULL >SOME (ARRAY[1,2,NULL])"

Review Comment:
   ```suggestion
       // "NULL > SOME (ARRAY[1,2,NULL])"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to