mihaibudiu commented on code in PR #4400:
URL: https://github.com/apache/calcite/pull/4400#discussion_r2135311873
##########
core/src/test/java/org/apache/calcite/test/RexImplicationCheckerTest.java:
##########
@@ -360,6 +361,116 @@ public class RexImplicationCheckerTest {
hasToString("2014"));
}
+ /** Test case for
Review Comment:
It's probably not the right class for the tests, but indeed, the other tests
don't belong here either. So perhaps you can add them here.
Here is the JavaDoc of RexInterpreter:
```
* Evaluates {@link RexNode} expressions.
*
* <p>Caveats:
* <ul>
* <li>It uses interpretation, so it is not very efficient.
* <li>It is intended for testing, so does not cover very many functions
and
* operators. (Feel free to contribute more!)
* <li>It is not well tested.
* </ul>
```
So this class is not really designed for optimizing programs, rather for
testing programs. But perhaps your use of it is just for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
