strongduanmu commented on code in PR #4411:
URL: https://github.com/apache/calcite/pull/4411#discussion_r2136722019


##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -5903,13 +5904,21 @@ SqlTypeNameSpec SqlTypeName1(Span s) :
     |
         <BOOLEAN> { s.add(this); sqlTypeName = SqlTypeName.BOOLEAN; }
     |
-        ( <INTEGER> | <INT> ) { s.add(this); sqlTypeName = 
SqlTypeName.INTEGER; }
+        ( <INTEGER> | <INT> ) ( <UNSIGNED> { unsigned = true; })? {

Review Comment:
   Considering that not all databases support `UNSIGNED` types, can we add 
`conformance.allowUnsignedType()` to perform checks?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to