suibianwanwank commented on code in PR #4392:
URL: https://github.com/apache/calcite/pull/4392#discussion_r2137372206
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -1526,6 +1526,33 @@ LogicalJoin(condition=[=($1, $12)], joinType=[semi])
LogicalTableScan(table=[[scott, DEPT]])
LogicalTableScan(table=[[scott, EMP]])
LogicalTableScan(table=[[scott, BONUS]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testCartesianProductForDphyp">
+ <Resource name="sql">
+ <![CDATA[select emp.empno from emp_address, emp, emp_b, dept where
emp_address.empno = emp.empno and dept.deptno = emp.deptno]]>
+ </Resource>
+ <Resource name="planBefore">
+ <![CDATA[
+LogicalProject(EMPNO=[$3])
+ HyperGraph(edges=[{0}——[INNER, =(vertex(0)_field(0),
vertex(1)_field(0))]——{1},{0, 1}——[INNER, true]——{2},{1}——[INNER,
=(vertex(3)_field(0), vertex(1)_field(7))]——{3}])
Review Comment:
Perhaps we need to add some ways to observe the DP process (could be hooks
or verbose logs), similar to MySQL's DynamicTable log? When users apply this
rule and want to adjust the cost model, it might function as a black box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
