xuzifu666 commented on code in PR #4419:
URL: https://github.com/apache/calcite/pull/4419#discussion_r2149774451
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -783,17 +783,23 @@ public SqlNode toSql(@Nullable RexProgram program,
RexNode rex) {
case IN:
case SOME:
case ALL:
- subQuery = (RexSubQuery) rex;
- sqlSubQuery = implementor().visitRoot(subQuery.rel).asQueryOrValues();
- final List<RexNode> operands = subQuery.operands;
- SqlNode op0;
- if (operands.size() == 1) {
- op0 = toSql(program, operands.get(0));
- } else {
- final List<SqlNode> cols = toSql(program, operands);
- op0 = new SqlNodeList(cols, POS);
+ if (rex instanceof RexSubQuery) {
+ subQuery = (RexSubQuery) rex;
+ sqlSubQuery =
implementor().visitRoot(subQuery.rel).asQueryOrValues();
+ final List<RexNode> operands = subQuery.operands;
+ SqlNode op0;
+ if (operands.size() == 1) {
+ op0 = toSql(program, operands.get(0));
+ } else {
+ final List<SqlNode> cols = toSql(program, operands);
+ op0 = new SqlNodeList(cols, POS);
+ }
+ return subQuery.getOperator().createCall(POS, op0, sqlSubQuery);
}
- return subQuery.getOperator().createCall(POS, op0, sqlSubQuery);
+ if (rex instanceof RexOver) {
Review Comment:
Thanks for reminder, here may not need the logic and I remove it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
