xiedeyantu commented on code in PR #4411:
URL: https://github.com/apache/calcite/pull/4411#discussion_r2149999185


##########
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##########
@@ -1961,6 +1977,10 @@ private static Comparable zeroValue(RelDataType type) {
     case SMALLINT:
     case INTEGER:
     case BIGINT:
+    case UTINYINT:

Review Comment:
   Call the `hasLiterals`, the type `UTINYINT`, `USMALLINT`, `UINTEGER`, 
`UBIGINT` will return false. But in `zeroValue`, these types can return 
`BigDecimal.ZERO`. the `zeroValue` use to make zero literal. Is it that I 
understand something wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to