suibianwanwank commented on code in PR #4422:
URL: https://github.com/apache/calcite/pull/4422#discussion_r2153579795


##########
core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java:
##########
@@ -1419,6 +1419,49 @@ public static boolean equalAsStructSansNullability(
     return true;
   }
 
+  /** Returns whether two types are equal, where two ROW types are considered 
equal
+   * even if the field names differ. */
+  public static boolean equalUpToFieldNames(RelDataType type1, RelDataType 
type2) {

Review Comment:
   Does this method express the same logic as the code below? From what I 
recall, we should have a similar method:
   ```
       String x = type1.getFullTypeString();
       String y = type2.getFullTypeString();
       return x.equal(y);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to