xuzifu666 commented on code in PR #4431:
URL: https://github.com/apache/calcite/pull/4431#discussion_r2160966046


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1191,7 +1191,7 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding 
operatorBinding,
    *
    * <p>It accepts at least 1 argument and returns null if any of
    * the arguments is null. */
-  @LibraryOperator(libraries = {MYSQL, BIG_QUERY})
+  @LibraryOperator(libraries = {BIG_QUERY})

Review Comment:
   
https://cloud.google.com/bigquery/docs/reference/standard-sql/string_functions#concat
   From this document, it seems that BigQuery should not keep the same behavior 
as MySQL's concat function( BigQuery return string or bytes,  MySQL return 
string or bytes string ),  but I don't have a corresponding test environment to 
verify BigQuery. In addition, this issue is mainly to solve the MySQL concat 
compatibility issue, so I keep BigQuery's concat function as before.  
   
https://dev.mysql.com/doc/refman/8.4/en/string-functions.html#function_concat 
   from MySQL document, The document clearly states that the returned results 
are all strings. @NobiGo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to