xuzifu666 commented on code in PR #4440:
URL: https://github.com/apache/calcite/pull/4440#discussion_r2167911527
##########
core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java:
##########
@@ -293,4 +294,10 @@ private static void assertCanCast(RelDataType toType,
RelDataType fromType) {
"Expected to be able to cast from %s to %s without coercion.",
fromType, toType),
SqlTypeUtil.canCastFrom(toType, fromType, /* coerce= */ defaultRules),
is(true));
}
+
+ @Test void testJavaToSqlByteStringMapping() {
Review Comment:
I thought maybe also need to add such as a sql test case when would be
unexpected before the PR? This feels a bit abstract and can not explain user
scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
