mihaibudiu commented on code in PR #4453:
URL: https://github.com/apache/calcite/pull/4453#discussion_r2175615673
##########
core/src/main/java/org/apache/calcite/sql/SqlMapTypeNameSpec.java:
##########
@@ -46,6 +56,29 @@ public SqlMapTypeNameSpec(SqlDataTypeSpec keyType,
SqlDataTypeSpec valType, SqlP
this.valType = valType;
}
+ /**
+ * Creates a {@code SqlMapTypeNameSpec}.
+ *
+ * @param keyType key type
Review Comment:
the documentation for some of these is not really helpful.
You should give an example showing how they will be used in uparsing.
##########
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java:
##########
@@ -118,36 +122,63 @@ public ClickHouseSqlDialect(Context context) {
}
@Override public @Nullable SqlNode getCastSpec(RelDataType type) {
- if (type instanceof BasicSqlType) {
- SqlTypeName typeName = type.getSqlTypeName();
- switch (typeName) {
- case CHAR:
- return createSqlDataTypeSpecByName(
- String.format(Locale.ROOT, "FixedString(%s)",
- type.getPrecision()), typeName, type.isNullable());
- case VARCHAR:
- return createSqlDataTypeSpecByName("String", typeName,
type.isNullable());
- case TINYINT:
- return createSqlDataTypeSpecByName("Int8", typeName,
type.isNullable());
- case SMALLINT:
- return createSqlDataTypeSpecByName("Int16", typeName,
type.isNullable());
- case INTEGER:
- return createSqlDataTypeSpecByName("Int32", typeName,
type.isNullable());
- case BIGINT:
- return createSqlDataTypeSpecByName("Int64", typeName,
type.isNullable());
- case REAL:
- return createSqlDataTypeSpecByName("Float32", typeName,
type.isNullable());
- case FLOAT:
- case DOUBLE:
- return createSqlDataTypeSpecByName("Float64", typeName,
type.isNullable());
- case DATE:
- return createSqlDataTypeSpecByName("Date", typeName,
type.isNullable());
- case TIMESTAMP:
- case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
- return createSqlDataTypeSpecByName("DateTime", typeName,
type.isNullable());
- default:
- break;
- }
+ SqlTypeName typeName = type.getSqlTypeName();
+ switch (typeName) {
+ case CHAR:
+ return createSqlDataTypeSpecByName(
+ String.format(Locale.ROOT, "FixedString(%s)",
+ type.getPrecision()), typeName, type.isNullable());
+ case VARCHAR:
+ return createSqlDataTypeSpecByName("String", typeName,
type.isNullable());
+ case TINYINT:
+ return createSqlDataTypeSpecByName("Int8", typeName, type.isNullable());
+ case SMALLINT:
+ return createSqlDataTypeSpecByName("Int16", typeName, type.isNullable());
+ case INTEGER:
+ return createSqlDataTypeSpecByName("Int32", typeName, type.isNullable());
+ case BIGINT:
+ return createSqlDataTypeSpecByName("Int64", typeName, type.isNullable());
+ case REAL:
+ return createSqlDataTypeSpecByName("Float32", typeName,
type.isNullable());
+ case FLOAT:
+ case DOUBLE:
+ return createSqlDataTypeSpecByName("Float64", typeName,
type.isNullable());
+ case DATE:
+ return createSqlDataTypeSpecByName("Date", typeName, type.isNullable());
+ case TIMESTAMP:
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ return createSqlDataTypeSpecByName("DateTime", typeName,
type.isNullable());
+ case MAP:
+ MapSqlType mapSqlType = (MapSqlType) type;
Review Comment:
I wonder if it's not better to create a custom class ClickHouseMapSqlType
instead of changing the existing classes.
##########
core/src/main/java/org/apache/calcite/sql/SqlCollectionTypeNameSpec.java:
##########
@@ -76,6 +84,31 @@ public SqlCollectionTypeNameSpec(SqlTypeNameSpec
elementTypeName,
requireNonNull(collectionTypeName, "collectionTypeName");
}
+ /**
+ * Creates a {@code SqlCollectionTypeNameSpec}.
+ *
+ * @param elementTypeName Type of the collection element
+ * @param collectionTypeName Collection type name
+ * @param pos Parser position, must not be null
+ * @param customName customName of CollectionType
Review Comment:
these 3 properties need better documentation; an example would help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
