NobiGo commented on code in PR #4447: URL: https://github.com/apache/calcite/pull/4447#discussion_r2178796024
########## core/src/main/java/org/apache/calcite/rel/rules/FullToLeftAndRightJoinRule.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.rules; + +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.plan.RelRule; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Join; +import org.apache.calcite.rel.core.JoinRelType; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.rex.RexShuttle; +import org.apache.calcite.rex.RexUtil; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.tools.RelBuilder; + +import com.google.common.collect.ImmutableList; + +import org.immutables.value.Value; + +/** + * Planner rule that matches a {@link Join} + * that join type is FULL, and convert it to + * a LEFT JOIN and RIGHT JOIN combination + * with a UNION ALL above them. + * + * <p>The SQL example is as follows: + * + * <pre>{@code + * SELECT * + * FROM Employees e + * FULL JOIN Departments d ON e.id = d.id + * }</pre> + * + * <p>rewritten into + * + * <pre>{@code + * SELECT * + * FROM Employees e + * LEFT JOIN Departments d ON e.id = d.id + * UNION ALL + * SELECT * + * FROM Employees e + * RIGHT JOIN Departments d ON e.id = d.id + * WHERE (e.id = d.id) IS NOT TRUE; + * }</pre> + */ [email protected] +public class FullToLeftAndRightJoinRule + extends RelRule<FullToLeftAndRightJoinRule.Config> + implements TransformationRule { + + /** Creates an FullToLeftAndRightJoinRule. */ + protected FullToLeftAndRightJoinRule(Config config) { + super(config); + } + + //~ Methods ---------------------------------------------------------------- + + @Override public void onMatch(RelOptRuleCall call) { + final Join join = call.rel(0); + RelBuilder relBuilder = call.builder(); + + if (!RexUtil.isDeterministic(join.getCondition())) { + return; + } + RexBuilder rexBuilder = relBuilder.getRexBuilder(); + RexNode newCondition = + rexBuilder.makeCall(SqlStdOperatorTable.IS_NOT_TRUE, join.getCondition()); + + final RexShuttle shuttle = new RexShuttle() { Review Comment: Is it possible to simply return to: ``` return RexInputRef.of(inputRef.getIndex(), join.getRowType()); ``` remove the if-condition? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
