NobiGo commented on code in PR #4456:
URL: https://github.com/apache/calcite/pull/4456#discussion_r2181394907
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -182,10 +183,17 @@ protected SqlImplementor(SqlDialect dialect) {
/** Visits a relational expression that has no parent. */
public final Result visitRoot(RelNode r) {
RelNode best;
- if (!this.dialect.supportsGroupByLiteral()) {
+ if (!this.dialect.supportsGroupByLiteral()
Review Comment:
Here, regardless of whether there is a FULL JOIN in the original plan or
not, the optimization will be carried out. In the RelToSqlConverter, it will
only be performed when there is a FULL JOIN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
