xiedeyantu commented on code in PR #4461: URL: https://github.com/apache/calcite/pull/4461#discussion_r2193680943
########## site/_docs/history.md: ########## @@ -132,7 +132,7 @@ Taking `RexBuilder#makeIn($0, ARRAY [100, 200], ARRAY [300, 400])` as an example Before: `OR(=($0, ARRAY(100, 200)), =($0, ARRAY(300, 400)))` After: `SEARCH($0, Sarg[[100:INTEGER, 200:INTEGER]:INTEGER NOT NULL ARRAY, [300:INTEGER, 400:INTEGER]:INTEGER NOT NULL ARRAY]:INTEGER NOT NULL ARRAY)` -* [<a href="https://issues.apache.org/jira/browse/CALCITE-6959";>CALCITE-6959</a>] +* [<a href="https://issues.apache.org/jira/browse/CALCITE-6959";>CALCITE-6959</a>] Support `LogicalAsofJoin` in `RelShuttle`. * [<a href="https://issues.apache.org/jira/browse/CALCITE-6961";>CALCITE-6961</a>] Addition of non-default methods for `LogicalAsofJoin` and `LogicalRepeatUnion`, respectively, to `RelShuttle`. Review Comment: Do we split the two descriptions, or fit the two CALCITE-X into one line? Because it looks strange on the website, 6959 has no description at all, but 6961 has accomplished two things. If you think the current format is okay, then I will close this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
