Dwrite commented on code in PR #4339:
URL: https://github.com/apache/calcite/pull/4339#discussion_r2213658815
##########
core/src/main/java/org/apache/calcite/sql/parser/StringAndPos.java:
##########
@@ -65,6 +101,10 @@ private StringAndPos(String sql, int cursor, @Nullable
SqlParserPos pos) {
* </ul>
*/
public static StringAndPos of(String sql) {
+
+ if (BITXOR_OPERATOR_WHITELISTED_SQLS.contains(sql)) {
Review Comment:
Thanks for the suggestion!
I've updated the implementation to support an escape mechanism in
StringAndPos, where ^^ is parsed into a single ^, similar to quote escaping.
I also added corresponding test cases in StringAndPosTest to verify the
behavior.
Let me know if you have any further comments — would appreciate another
round of review when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
