xiedeyantu commented on code in PR #4475:
URL: https://github.com/apache/calcite/pull/4475#discussion_r2223978667
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -17792,6 +17792,31 @@ LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2],
MGR=[$3], HIREDATE=[$4], SAL=[$
LogicalSort(sort0=[$7], sort1=[$0], dir0=[ASC], dir1=[ASC])
LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4],
SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8], EXPR$9=[null:NULL])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testSortRemoveDuplicateKeys">
+ <Resource name="sql">
+ <![CDATA[select d1
+ from (select deptno as d1, deptno as d2 from dept) as tmp
Review Comment:
This issue hasn't been fully understood yet. Duplicate keys should originate
from the same expression, and their NULLS FIRST property should be identical.
This rule only considers the removal of duplicate keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
