xiedeyantu commented on PR #4480: URL: https://github.com/apache/calcite/pull/4480#issuecomment-3130967409
> I would use 'assertThat' rather than 'assertEquals' in tests. I'd also add a test based on a simple query like 'select empno, deptno, deptno + 1 from emp where deptno < 20' because simple tests are easier to understand, and a new kind of metadata requires doing the simple stuff well. > > +1 when you've done that. I added a case `textFunctionDependencySimple`, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
