bchapuis commented on code in PR #3668: URL: https://github.com/apache/calcite/pull/3668#discussion_r2243938634
########## core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java: ########## @@ -116,6 +117,7 @@ import org.checkerframework.checker.initialization.qual.UnknownInitialization; import org.checkerframework.checker.nullness.qual.Nullable; +import org.locationtech.jts.geom.Geometry; Review Comment: Would this imply adding a wrapper in Calcite to reduce coupling to JTS? I’m still not convinced that the added complexity is worth it. JTS is almost a standard for spatial functions and operators. GEOS, which is used in Postgis, is actually a C++ port of JTS, and their communities overlap significantly. To put it another way, I think JTS is almost to geometry what Guava is to immutable maps and lists ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
