xuzifu666 commented on code in PR #4488:
URL: https://github.com/apache/calcite/pull/4488#discussion_r2249990582
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -397,6 +403,22 @@ RexNode isFalse(RexNode e) {
: rexBuilder.makeCall(SqlStdOperatorTable.IS_FALSE, e);
}
+ /**
+ * Runs simplification unary function by eliminating idempotent.
+ */
+ private RexCall simplifUnaryFunction(RexCall rexCall) {
Review Comment:
This is a bit like a special case, because the two functions have opposite
effects. Maybe can hand this case, and it will not affect the default behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
